Skip to content

Add Typescript definition #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 2, 2019
Merged

Add Typescript definition #7

merged 4 commits into from
Mar 2, 2019

Conversation

satyarohith
Copy link
Contributor

No description provided.

@satyarohith
Copy link
Contributor Author

@sindresorhus Thanks for the help! Learned about ArrayLike. Let me know if the solution isn't correct!

@satyarohith satyarohith changed the title [WIP] Add Typescript definition Add Typescript definition Feb 20, 2019
@sindresorhus
Copy link
Owner

For packages with a default export, use export default foo;, not export = foo;. You will have to add module.exports.default = foo; to the index.js file.

@satyarohith
Copy link
Contributor Author

@sindresorhus Sorry for that! I have updated.

@sindresorhus sindresorhus merged commit 1a86629 into sindresorhus:master Mar 2, 2019
sindresorhus added a commit that referenced this pull request Mar 2, 2019
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
sindresorhus added a commit that referenced this pull request Mar 2, 2019
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
@satyarohith satyarohith deleted the add-types branch March 3, 2019 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants