Feature/user comment #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essary other entities with migration file
…ted necessary other entities with migration file
… - updated necessary other entities with migration file
…to list trick comments on single trick page with their potential hierarchy due to possible parent comments
…rchy as concerns replies with descending order - adapted trick comment creation form parent comment field if no previous comment is available
…omment creation form using smooth scroll behaviour - managed parent comment to reply select dropdown value update with this process to prefill the field before validation
…reach comment creation form using smooth scroll behaviour - managed parent comment to reply select dropdown value update with this process to prefill the field before validation
…ons, AJAX action and particular confirmation modal
…ss - improved also home AJAX trick list process - fixed message string formatting as concerns JS notification function for toast display
…sier to understand
…xists for single trick page
|
Merge accepted! Please note that: It's time to finish project development as soon as possible! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch creates trick comment creation form process (with trick comment deletion process) and trick comment list display on single page.
This merge aims at testing better workflow with development and features branches added to master. No issue is referenced for this pull request.
This branch treated expected changes and "fixed" issue: #17
Added trick comment creation form action, and displayed this form on single trick page
Added trick comment deletion action with AJAX confirmation modal without form but with CSRF token and DELETE request
Added comment author or admin deletion authorization control
Listed trick comments in descending order with parent/children list hierarchy as possible reply(ies)
Added JS "reply" select drop down pre-fill action with individual button, to make use of comment creation form more efficient
Added comment list sequential AJAX loading with effect and replies JS toggle functionality
Reorganized Twig templates structure to be more readable
Made several improvements on application to make UX better and fixed a few bugs
Cleaned some PHP and JS scripts and phpDoc
These pages or functionalities need to be tested to limit possible bugs, despite the use of xdebug on branch.
Message: please accept this merge and be conscious some little changes can be made later.