Skip to content

Updates to match template (workflows) #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 3, 2023
Merged

Updates to match template (workflows) #1

merged 4 commits into from
Apr 3, 2023

Conversation

sinsukehlab
Copy link
Contributor

Why:

2 warnings
Check current step number and On start
Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
Check current step number
The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

What's being changed:

  • Bump actions/checkout@v2 to v3
  • Stop using set-output commands
  • Fix 4-personalize-codespace.yml

Check off the following:

  • For workflow changes, I have verified the Actions workflows function as expected.
  • For content changes, I have reviewed the style guide.

@sinsukehlab
Copy link
Contributor Author

README.md also needs updating to match the template.

@heiskr heiskr requested a review from a team April 3, 2023 15:15
heiskr
heiskr approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@heiskr heiskr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💖

@heiskr heiskr merged commit 587480b into skills:main Apr 3, 2023
Vue-Pu
Vue-Pu reviewed Apr 24, 2023
View reviewed changes
Copy link

@Vue-Pu Vue-Pu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.github/workflows/4-personalize-codespace.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vue-Pu Vue-Pu Vue-Pu left review comments

@heiskr heiskr heiskr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sinsukehlab @heiskr @Vue-Pu