Skip to content

Step 4: Name dotfiles install script 'install.sh' #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Step 4: Name dotfiles install script 'install.sh' #99

wants to merge 1 commit into from

Conversation

czmoss
Copy link

@czmoss czmoss commented Jun 12, 2024 •
edited
Loading

Summary

Using 'setup.sh' does not seem to work to initiate dotfiles installation (even though it is documented to).

Changes

Replace 'setup.sh' with 'install.sh', as install.sh does seem to work as expected.

Closes: #98

Task list

  • For workflow changes, I have verified the Actions workflows function as expected.
  • [ ] For content changes, I have reviewed the style guide.
    I think there were no style-implicated content changes.

@czmoss
Step 4: Name dotfiles install script 'install.sh'
917b160 
Apparently, and as opposed to [what is documented][dotfiles], a file
named 'setup.sh' does not work to direct the installation of dotfiles
into a newly created Codespace.  While the GitHub Codespaces team works
to fix that bug, let's have students instead name the file 'install.sh',
which does seem to work.

[dotfiles]: https://docs.github.com/en/codespaces/setting-your-user-preferences/personalizing-github-codespaces-for-your-account#dotfiles
@heiskr heiskr requested a review from a team July 1, 2024 15:49
@hectorsector
Copy link
Contributor

hectorsector commented Jul 2, 2024 •
edited
Loading

Thanks for the PR, @czmoss! In this case, there are issues with setting the path. Using a different dotfile probably won't help with that, so I'll mark this as closed but I'll edit the original issue you created to make it easier to tackle. Your report and PR are both very helpful in getting this resolved ❤️

@czmoss
Copy link
Author

czmoss commented Jul 6, 2024

Thanks for the reply, @hectorsector!

My original problem wasn't that PATH wasn't set, it was that the dotfiles were not installed correctly. If I remember correctly, the dotfiles repository would be cloned into the correct place in the Codespace (/workspaces/.codespaces/.persistedshare/dotfiles/), but the setup.sh script wouldn't run.

(Indeed, my original problem couldn't have been that PATH wasn't set, because that came about in #103, which was a follow-up on #83, neither of which hadn't been completed when I started the course.)

Anyway, I just redid the course to test whether my original issue still existed. It seems it doesn't: setup.sh is clearly run as indicated in /workspaces/.codespaces/.persistedshare/creation.log. (Attached: creation.log; and I'm sorry that I didn't think to attach my creation.log files from earlier attempts.)

So, I agree that there is no longer any need for the specific change I proposed, here.

@czmoss czmoss mentioned this pull request Jul 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Using 'setup.sh' in step 4 doesn't work
2 participants
@czmoss @hectorsector