Skip to content

Make a decision about statistical functions in src/stat/stat.jl #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sl-solution opened this issue Dec 14, 2021 · 4 comments
Open

Make a decision about statistical functions in src/stat/stat.jl #32

sl-solution opened this issue Dec 14, 2021 · 4 comments
Labels
decision enhancement New feature or request

Comments

@sl-solution
Copy link
Owner

currently we redefined them for vector with missing values.
@sl-solution sl-solution added enhancement New feature or request decision labels Dec 14, 2021
@giordano
Copy link

Also the entire file https://github.com/sl-solution/InMemoryDatasets.jl/blob/9f781c309f90f1a4c1623f0e85c78209bf9d1b9a/src/missings/missings.jl is type piracy

@George9000
Copy link

Posting a link to Eric Hanson's post on this issue on the Julia Discourse. The concerns raised about unexpected behavior, bugs, and non-composability need to be considered carefully. Data science workflows grow to use multiple packages for various functionality over time. It would be good to avoid unpredictability arising from changing Base behavior.

@sl-solution
Copy link
Owner Author

Also the entire file https://github.com/sl-solution/InMemoryDatasets.jl/blob/9f781c309f90f1a4c1623f0e85c78209bf9d1b9a/src/missings/missings.jl is type piracy

fixed.

sl-solution added a commit that referenced this issue Mar 22, 2022
@sl-solution
fixing #32
209c72e
@sl-solution
Copy link
Owner Author

you may check master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
decision enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@giordano @George9000 @sl-solution