removed Plots and UMAP, removed Manifest #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, just FYI you didn't need to close the previous PR (Linking here as #10 for reference). |
slycoder
reviewed
May 31, 2020
| @@ -1 +1,3 @@ | |||
| .DS_Store | |||
| *.jld | |||
| Manifest.toml | |||
There was a problem hiding this comment.
Should manifest be ignored or committed? If it's like package management in a few other languages it seems like something that should be kept to ensure that git-shas are maintained.
|
I think the general consensus is to not commit Manifest.toml (I just did a
quick check on DifferentialEquations.jl, Distributions.jl, Optim.jl),
although it is useful for for reproducing a specific environment.
For instance, if you had an MWE on an issue you could run "Pkg.activate
<cloned repo's root directory> and running Pkg.instantiate to pull in stuff
from "<cloned repo's root directory>/Manifest.toml".
However, Manifest.toml doesn't enforce versions of deps. In fact, if you
call Pkg.build with no Manifest.toml present, it installs all deps at
versions consistent with the [compat] field in Project.toml, then generate
a Manifest.toml consistent with this, which by default is in the home
project (~/.julia/environments/v1.4/Manifest.toml).
I do generate a Manifest.toml in the package dir for my development
workflow but it only serves as a record. It gets generated automatically
whenever I run Pkg.build with the project directory activated.
Hope that helps!
…On Sat, May 30, 2020 at 5:04 PM Jonathan Chang ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .gitignore
<#11 (comment)>
:
> @@ -1 +1,3 @@
.DS_Store
+*.jld
+Manifest.toml
Should manifest be ignored or committed? If it's like package management
in a few other languages it seems like something that should be kept to
ensure that git-shas are maintained.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#11 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACRZ455T2OTANAGVZBR3LDRUGNHTANCNFSM4NO4XG3A>
.
|
|
Thank you for that explanation! |
slycoder
approved these changes
May 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just fixed previous PR as discussed