Fix tests with Python 3.13 #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3.13 dedents all docstrings, while older versions only stripped initial whitespace (from the first line). To achieve consistent matches across all Python versions, use a regular expression to dedent all lines in both cases. Furthermore, the docstring of `functools.partial()` has changed. Rather than hardcoding one, just match against `functools.partial.__doc__`. Fixes smarie#102
|
Thanks @mgorny . Since python 3.13 is not in the CI today, you also need to add it to the noxfile.py, so that the issue that you are describing actually happens. I would advise to
|
|
Thanks but I'm not interested in performing the maintenance tasks for this package. |
|
No worries @mgorny , I understand |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: Fixes #102
Python 3.13 dedents all docstrings, while older versions only stripped initial whitespace (from the first line). To achieve consistent matches across all Python versions, use a regular expression to dedent all lines in both cases.
Furthermore, the docstring of
functools.partial()has changed. Rather than hardcoding one, just match againstfunctools.partial.__doc__.