Skip to content

Match type exactly when checking TYPES_WITH_SAFE_REPR #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 2, 2024

Conversation

moskupols
Copy link

This fixes #98

My understanding is that here we are trying to say whether a builtin literal for str, int, bytes, or bool would produce the same value as given. However, that is only possible if the given value has one of these types.

@smarie
Copy link
Owner

smarie commented Mar 12, 2024

Hi @moskupols thanks for this Proposal ! Indeed it makes sense.
Could you please update your branch to the latest ? I just switched the nox backend to virtualenv for convenience. Note that you'll need "nox==2022.11.21" and "virtualenv==16" to be able to create all nox sessions including those for python 2.7, 3.5 3.6 and 3.7.

@moskupols
Copy link
Author

Hi @smarie !
I've just merged main and updated the test so that it runs on earlier versions of python as well.

@moskupols
Copy link
Author

Hi @smarie ! Is there a chance to merge the PR?

@smarie smarie merged commit 7c95496 into smarie:main Jul 2, 2024
@smarie
Copy link
Owner

smarie commented Jul 2, 2024

Thanks @moskupols and sorry for the delay !

@AlexeyDmitriev
Copy link

@smarie do you have an approximation when next version wiil be released?

@smarie
Copy link
Owner

smarie commented Jul 3, 2024

Hi @AlexeyDmitriev and @moskupols , thanks for your feedback ! I was expecting to release it just after merging yesterday, but unfortunately there is an issue in my build system (#105 ). I'll try to find 15' to fix this by the end of the week, hopefully it is just a matter of getting rid of nox_utils.py and using the proper nox.parametrize routines, now that they are available.

@smarie
Copy link
Owner

smarie commented Jul 5, 2024

1.15.3 is now released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't wrap function with StrEnum as argument with default
4 participants