Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: socketio/engine.io
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: f62f265
Choose a base ref
...
head repository: socketio/engine.io
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 67a3a87
Choose a head ref
  • 2 commits
  • 3 files changed
  • 1 contributor

Commits on Nov 20, 2022

  1. fix: catch errors when destroying invalid upgrades 

    Before this change, receiving an HTTP2 upgrade would make the server
crash:

> Error: read ECONNRESET
>    at TCP.onStreamRead (node:internal/stream_base_commons:217:20) {
>  errno: -104,
>  code: 'ECONNRESET',
>  syscall: 'read'
> }

This can be reproduced with Node.js v14.15.3, v16.18.1 and v18.12.1.

Backported from 425e833
    @darrachequesne
    darrachequesne committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    83c4071 View commit details
    Browse the repository at this point in the history

  2. chore(release): 3.6.1 

    Diff: 3.6.0...3.6.1
    @darrachequesne
    darrachequesne committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    67a3a87 View commit details
    Browse the repository at this point in the history
Loading