Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: socketio/engine.io-client
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 3.4.4
Choose a base ref
...
head repository: socketio/engine.io-client
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3.5.0
Choose a head ref
  • 4 commits
  • 8 files changed
  • 1 contributor

Commits on Dec 30, 2020

  1. ci: migrate to GitHub Actions 

    Due to the recent changes to the Travis CI platform (see [1]), we will
now use GitHub Actions to run the tests.

Reference: https://docs.github.com/en/free-pro-team@latest/actions/guides/building-and-testing-nodejs

[1]: https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing

Backported from master: 20f7fe0
    @darrachequesne
    darrachequesne committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    f764bf6 View commit details
    Browse the repository at this point in the history

  2. chore: bump ws version

    @darrachequesne
    darrachequesne committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    0b254ce View commit details
    Browse the repository at this point in the history

  3. fix: check the type of the initial packet 

    Before this fix, the client could mark the polling transport as open
even though the handshake packet was not received properly (for
example, after a parsing error).

This could lead to writes (POST requests) without "sid" query param,
which failed with:

```
{"code":2,"message":"Bad handshake method"}
```

Related:

- #636
- socketio/socket.io-client#1390

Cherry-picked from master: 1c8cba8
    @darrachequesne
    darrachequesne committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    8750356 View commit details
    Browse the repository at this point in the history

  4. chore(release): 3.5.0 

    Diff: 3.4.4...3.5.0
    @darrachequesne
    darrachequesne committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    b1630ba View commit details
    Browse the repository at this point in the history
Loading