Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: socketio/engine.io-client
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 6.2.3
Choose a base ref
...
head repository: socketio/engine.io-client
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6.3.0
Choose a head ref
  • 12 commits
  • 44 files changed
  • 3 contributors

Commits on Dec 9, 2022

  1. feat: add the "addTrailingSlash" option (#694)

    The "addTrailingSlash" option allows to control whether a trailing
    slash is added to the path of the HTTP requests created by the library:
    
    - true (default): "/engine.io/"
    - false: "/engine.io"
    
    Related: socketio/socket.io-client#1550
    
    Signed-off-by: iifawzi <iifawzie@gmail.com>
    iifawzi authored and darrachequesne committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    21a6e12 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    824ab4c View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2022

  1. ci: temporarily disable browser tests

    The tests are in failure since the 13th November, without any logs from
    Saucelabs, so we temporarily disable them until further investigation.
    
    See: https://github.com/socketio/engine.io-client/actions/runs/3453198221
    darrachequesne committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    6565c8e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    721837c View commit details
    Browse the repository at this point in the history
  3. refactor: bump prettier to version 2.8.1

    This major bump creates a lot of noise, but it is necessary for
    prettier to be able to parse new syntax such as:
    
    - typed imports: `import { type xxx } from ...`
    - private attributes: `class A { #b; #c() {} }`
    darrachequesne committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    528a61f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2ddcb82 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2022

  1. refactor: improve typings

    Note: `readyState` and `writeBuffer` are set to public, as they might
    be useful for the end user.
    darrachequesne committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    ec5a596 View commit details
    Browse the repository at this point in the history
  2. refactor: remove unused option

    This option was added by error during the TypeScript migration.
    
    Related: 587ccf3
    darrachequesne committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    1eaeeec View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ed6d016 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2023

  1. fix: properly parse relative URL with a "@" character

    A query parameter with a "@" character could be incorrectly parsed.
    
    Example: "/foo?bar=@example.com" => host: example.com
    
    The parse() method is also used in the `socket.io-client` package, to
    extract the namespace and the query parameters.
    
    Notes:
    
    - this bug does not seem exploitable, as an attacker would need to
    inject the query parameter in the code executed by the client.
    
    - we might use the URL object in the next major version, but that
    means dropping support for some platforms such as IE
    
    Reference: https://caniuse.com/url
    
    Thanks to Li Jiantao of STAR Labs (@starlabs_sg) for the responsible
    disclosure.
    darrachequesne committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    12b7d78 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2023

  1. fix: use explicit context for setTimeout function (#699)

    In order to fix "Illegal invocation" errors that happen on some
    platforms.
    zongzi531 authored Jan 10, 2023
    Configuration menu
    Copy the full SHA
    047f420 View commit details
    Browse the repository at this point in the history
  2. chore(release): 6.3.0

    darrachequesne committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    e2b39b6 View commit details
    Browse the repository at this point in the history
Loading