Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: socketio/engine.io-client
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 6.5.0
Choose a base ref
...
head repository: socketio/engine.io-client
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6.5.1
Choose a head ref
  • 7 commits
  • 11 files changed
  • 1 contributor

Commits on Jun 16, 2023

  1. chore: update bundle

    darrachequesne committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    01804d5 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2023

  1. Configuration menu
    Copy the full SHA
    cf6aa1f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6404391 View commit details
    Browse the repository at this point in the history
  3. refactor: expose the ESM build with debug

    So that debug logs can be printed with vite:
    
    ```js
    import { defineConfig } from 'vite'
    import react from '@vitejs/plugin-react'
    
    export default defineConfig({
      plugins: [react()],
      server: {
        port: 4000
      },
      resolve: {
        conditions: ["development"]
      }
    })
    ```
    
    Reference: https://v2.vitejs.dev/config/#resolve-conditions
    
    Related: socketio/socket.io-client@781d753
    darrachequesne committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    fe4d93a View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2023

  1. refactor: expose the ESM build with debug (bis)

    This reverts the previous commit ([1]), and expose the ESM build that
    includes the debug package on a subpath:
    
    ```js
    import { Socket } from "engine.io-client/debug";
    ```
    
    Reference: https://nodejs.org/api/packages.html#subpath-exports
    
    Related: https://github.com/socketio/socket.io-client/issues/1586
    
    [1]: fe4d93a
    darrachequesne committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    1fc61a3 View commit details
    Browse the repository at this point in the history
  2. fix: make closeOnBeforeunload default to false

    Silently closing the connection when receiving a "beforeunload" event
    is problematic, because it is emitted:
    
    - when downloading a file from another host
    
    Related: socketio/socket.io#4436
    
    - when the user already has a listener for the "beforeunload" event
    (i.e. "are you sure you want to leave this page?")
    
    Related:
    
    - #661
    - #658
    - socketio/socket.io#4065
    
    That's why the `closeOnBeforeunload` option will now default to false.
    darrachequesne committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    a63066b View commit details
    Browse the repository at this point in the history
  3. chore(release): 6.5.1

    darrachequesne committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    500085d View commit details
    Browse the repository at this point in the history
Loading