Skip to content

Conversation

DimitarNestorov
Copy link
Contributor

@DimitarNestorov DimitarNestorov commented May 15, 2019

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

Current behaviour

New behaviour

Other information (e.g. related issues)

Syncing the version of debug throughout the repositories.
socketio/engine.io#581
socketio/socket.io-client#1304
socketio/socket.io-parser#92
socketio/socket.io-redis-emitter#82
socketio/socket.io-redis-adapter#306

@darrachequesne
Copy link
Member

Thanks 👍

@goto-bus-stop
Copy link

goto-bus-stop commented Sep 20, 2019

FWIW this was a breaking change because debug started using arrow functions. I see you've addressed it in socket.io's own tests but all downstream consumers would also have to add transpilation for the debug module to their builds to prevent breakage. (I'm just pinning to socket.io 2.2 for now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants