Skip to content

fix NullPointerException when response doesn't have content type #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix NullPointerException when response doesn't have content type #101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/main/java/io/socket/engineio/client/transports/PollingXHR.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,9 +268,9 @@ private void onResponseHeaders(Map<String, List<String>> headers) {

private void onLoad() {
ResponseBody body = response.body();
String contentType = body.contentType().toString();

try {
String contentType = getContentTypeFromBody(body);
if (BINARY_CONTENT_TYPE.equalsIgnoreCase(contentType)) {
this.onData(body.bytes());
} else {
Expand All @@ -281,6 +281,14 @@ private void onLoad() {
}
}

private String getContentTypeFromBody(ResponseBody body) {
MediaType mediaType = body.contentType();
if (mediaType == null) {
return "";
}
return mediaType.toString();
}

public static class Options {

public String uri;
Expand Down