-
Notifications
You must be signed in to change notification settings - Fork 101
Comparing changes
Open a pull request
base repository: socketio/socket.io-adapter
base: 2.5.2
head repository: socketio/socket.io-adapter
compare: 2.5.3
- 13 commits
- 8 files changed
- 1 contributor
Commits on Feb 20, 2024
-
refactor: import the ClusterAdapter abstract class
Imported from https://github.com/socketio/socket.io-redis-adapter/blob/ef5f0da0b4928fd422afc985aec0e233d34400c0/lib/cluster-adapter.ts This abstract class is currently used by the sharded Redis adapter. We import it here because the logic can be reused by the other adapters, which will then only need to handle the pub/sub mechanism.
Configuration menu - View commit details
-
Copy full SHA for b157e9e - Browse repository at this point
Copy the full SHA b157e9eView commit details -
Configuration menu - View commit details
-
Copy full SHA for b2d3695 - Browse repository at this point
Copy the full SHA b2d3695View commit details -
Configuration menu - View commit details
-
Copy full SHA for 80af4e9 - Browse repository at this point
Copy the full SHA 80af4e9View commit details -
fix(cluster): notify the other nodes when closing
The clustered adapter will now: - periodically check if a node has left the cluster - send an event when it leaves the cluster This should reduce the number of "timeout reached: only x responses received out of y" errors.
Configuration menu - View commit details
-
Copy full SHA for 0e23ff0 - Browse repository at this point
Copy the full SHA 0e23ff0View commit details -
refactor(cluster): allow to call onMessage() with a cluster response
The Redis adapter is currently the only adapter which makes a distinction between publishing messages (one channel for all) and responses (one channel for each node).
Configuration menu - View commit details
-
Copy full SHA for 1011ab3 - Browse repository at this point
Copy the full SHA 1011ab3View commit details -
refactor(cluster): catch publish errors
Note: the current API does not currently allow the user to handle those errors (and retry, for example). This might be worth investigating for the next major version, maybe something like: ```js try { await io.emit("hello"); } catch (e) { // something went wrong } ``` Related: socketio/socket.io-mongo-adapter#15
Configuration menu - View commit details
-
Copy full SHA for 39d4220 - Browse repository at this point
Copy the full SHA 39d4220View commit details -
Configuration menu - View commit details
-
Copy full SHA for d99a71b - Browse repository at this point
Copy the full SHA d99a71bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a6a215 - Browse repository at this point
Copy the full SHA 2a6a215View commit details
Commits on Feb 21, 2024
-
test(cluster): init the test suite for the clustered adapter
The test suite is imported from [1]. [1]: https://github.com/socketio/socket.io-postgres-adapter/blob/193883b9caefee4c6fa31f49d5f5197f4d9a8186/test/index.ts
Configuration menu - View commit details
-
Copy full SHA for 2df5e94 - Browse repository at this point
Copy the full SHA 2df5e94View commit details -
Reference: https://github.com/nodejs/Release
Configuration menu - View commit details
-
Copy full SHA for 48eddc1 - Browse repository at this point
Copy the full SHA 48eddc1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d8da64 - Browse repository at this point
Copy the full SHA 1d8da64View commit details -
refactor(cluster): make onMessage() method synchronous
The fetchSockets() method of the parent class is synchronous, so the onMessage() method does not need to be asynchronous.
Configuration menu - View commit details
-
Copy full SHA for 5dcd182 - Browse repository at this point
Copy the full SHA 5dcd182View commit details -
Configuration menu - View commit details
-
Copy full SHA for 549156c - Browse repository at this point
Copy the full SHA 549156cView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 2.5.2...2.5.3