Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: socketio/socket.io-client
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2.3.0
Choose a base ref
...
head repository: socketio/socket.io-client
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2.3.1
Choose a head ref
  • 12 commits
  • 15 files changed
  • 5 contributors

Commits on Sep 29, 2020

  1. test: fix race condition in the tests

    Even with a timeout of 0, the 'open' event was emitted before the
    timeout was reached, so the tests would randomly fail in the CI.
    darrachequesne committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    b7dbbd2 View commit details
    Browse the repository at this point in the history
  2. chore: bump component-emitter dependency (#1376)

    Subscribing/unsubscribing for a lot of different event types could lead
    to a memory leak.
    
    See sindresorhus/component-emitter@aa2e57a
    
    Diff: sindresorhus/component-emitter@1.2.1...1.3.0
    rookieKing authored Sep 29, 2020
    Configuration menu
    Copy the full SHA
    3c1d860 View commit details
    Browse the repository at this point in the history
  3. chore: update package-lock.json file

    Following previous commit, the lock file was not up-to-date.
    darrachequesne committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    f4a4d89 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6ce02ee View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2020

  1. Configuration menu
    Copy the full SHA
    0c39f14 View commit details
    Browse the repository at this point in the history
  2. chore: remove unused dependencies

    - base64-arraybuffer => dev
    - has-cors => dev
    - object-component => removed
    darrachequesne committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    1fb1b78 View commit details
    Browse the repository at this point in the history
  3. chore: bump engine.io-client and downgrade debug

    The newer versions need to be transpiled to ES5, so we'll rollback for
    now as it breaks IE11.
    
    We'll have to find a way to provide the users who bundle the Engine.IO
    (or Socket.IO) client (with webpack for example) with a source code
    which does not include debug (or document the usage of
    webpack-remove-debug [1]).
    
    [1] https://github.com/johngodley/webpack-remove-debug
    darrachequesne committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    b570025 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    050108b View commit details
    Browse the repository at this point in the history
  5. test: remove arrow function (for now)

    It was included by the previous commit, but the test code is not
    currently transpiled to ES5 so it breaks IE in the CI.
    
    Let's use a plain function for now.
    darrachequesne committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    15a52ab View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    67c54b8 View commit details
    Browse the repository at this point in the history
  7. test: fix tests in IE

    darrachequesne committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    7f73a28 View commit details
    Browse the repository at this point in the history
  8. chore(release): 2.3.1

    darrachequesne committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    4631ed6 View commit details
    Browse the repository at this point in the history
Loading