-
Notifications
You must be signed in to change notification settings - Fork 3k
Comparing changes
Open a pull request
base repository: socketio/socket.io-client
base: 2.3.0
head repository: socketio/socket.io-client
compare: 2.3.1
- 12 commits
- 15 files changed
- 5 contributors
Commits on Sep 29, 2020
-
test: fix race condition in the tests
Even with a timeout of 0, the 'open' event was emitted before the timeout was reached, so the tests would randomly fail in the CI.
Configuration menu - View commit details
-
Copy full SHA for b7dbbd2 - Browse repository at this point
Copy the full SHA b7dbbd2View commit details -
chore: bump component-emitter dependency (#1376)
Subscribing/unsubscribing for a lot of different event types could lead to a memory leak. See sindresorhus/component-emitter@aa2e57a Diff: sindresorhus/component-emitter@1.2.1...1.3.0
Configuration menu - View commit details
-
Copy full SHA for 3c1d860 - Browse repository at this point
Copy the full SHA 3c1d860View commit details -
chore: update package-lock.json file
Following previous commit, the lock file was not up-to-date.
Configuration menu - View commit details
-
Copy full SHA for f4a4d89 - Browse repository at this point
Copy the full SHA f4a4d89View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ce02ee - Browse repository at this point
Copy the full SHA 6ce02eeView commit details
Commits on Sep 30, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 0c39f14 - Browse repository at this point
Copy the full SHA 0c39f14View commit details -
chore: remove unused dependencies
- base64-arraybuffer => dev - has-cors => dev - object-component => removed
Configuration menu - View commit details
-
Copy full SHA for 1fb1b78 - Browse repository at this point
Copy the full SHA 1fb1b78View commit details -
chore: bump engine.io-client and downgrade debug
The newer versions need to be transpiled to ES5, so we'll rollback for now as it breaks IE11. We'll have to find a way to provide the users who bundle the Engine.IO (or Socket.IO) client (with webpack for example) with a source code which does not include debug (or document the usage of webpack-remove-debug [1]). [1] https://github.com/johngodley/webpack-remove-debug
Configuration menu - View commit details
-
Copy full SHA for b570025 - Browse repository at this point
Copy the full SHA b570025View commit details -
Configuration menu - View commit details
-
Copy full SHA for 050108b - Browse repository at this point
Copy the full SHA 050108bView commit details -
test: remove arrow function (for now)
It was included by the previous commit, but the test code is not currently transpiled to ES5 so it breaks IE in the CI. Let's use a plain function for now.
Configuration menu - View commit details
-
Copy full SHA for 15a52ab - Browse repository at this point
Copy the full SHA 15a52abView commit details -
chore: bump engine.io-parser and socket.io-parser
Diff: - socketio/engine.io-parser@2.2.0...2.2.1 - socketio/socket.io-parser@3.3.0...3.3.1 Related: - #1376 - #1234
Configuration menu - View commit details
-
Copy full SHA for 67c54b8 - Browse repository at this point
Copy the full SHA 67c54b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f73a28 - Browse repository at this point
Copy the full SHA 7f73a28View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4631ed6 - Browse repository at this point
Copy the full SHA 4631ed6View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 2.3.0...2.3.1