Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: socketio/socket.io-client
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4.6.0
Choose a base ref
...
head repository: socketio/socket.io-client
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 4.6.1
Choose a head ref
  • 4 commits
  • 14 files changed
  • 1 contributor

Commits on Feb 20, 2023

  1. fix: do not drain the queue while the socket is offline 

    In the previous implementation added in [1], the socket would try to
send the packet even if it was disconnected, which would needlessly
exhaust the number of retries.

[1]: 655dce9
    @darrachequesne
    darrachequesne committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    4996f9e View commit details
    Browse the repository at this point in the history

  2. fix: prevent duplicate connections when multiplexing 

    This bug was introduced in [1]: a multiplexed socket could in some
cases send multiple CONNECT packets, resulting in duplicate connections
on the server side.

A cached socket will now be reopened only if it was inactive, that is,
if one had explicitly called socket.disconnect() before.

Related: #1460

[1]: b7dd891
    @darrachequesne
    darrachequesne committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    46213a6 View commit details
    Browse the repository at this point in the history

  3. refactor: do not reuse the same packet ID for retries 

    The packet ID cannot be used for deduplication, because it's only
unique for the given session. If you reconnect on another server and
try to resend a packet, then the server won't be able to know whether
the packet has already been processed or not.
    @darrachequesne
    darrachequesne committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    121fd7c View commit details
    Browse the repository at this point in the history

  4. chore(release): 4.6.1 

    Diff: 4.6.0...4.6.1
    @darrachequesne
    darrachequesne committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    89175d0 View commit details
    Browse the repository at this point in the history
Loading