Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: socketio/socket.io-parser
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4b3c191
Choose a base ref
...
head repository: socketio/socket.io-parser
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 060339a
Choose a head ref
  • 2 commits
  • 5 files changed
  • 1 contributor

Commits on May 22, 2023

  1. fix: check the format of the event name 

    A packet like '2[{"toString":"foo"}]' was decoded as:

{
  type: EVENT,
  data: [ { "toString": "foo" } ]
}

Which would then throw an error when passed to the EventEmitter class:

> TypeError: Cannot convert object to primitive value
>    at Socket.emit (node:events:507:25)
>    at .../node_modules/socket.io/lib/socket.js:531:14

History of the isPayloadValid() method:

- added in [78f9fc2](78f9fc2) (v4.0.1, socket.io@3.0.0)
- updated in [1c220dd](1c220dd) (v4.0.4, socket.io@3.1.0)

Backported from 3b78117
    @darrachequesne
    darrachequesne committed May 22, 2023
    Configuration menu
    Copy the full SHA
    2dc3c92 View commit details
    Browse the repository at this point in the history

  2. chore(release): 3.4.3 

    Diff: 3.4.2...3.4.3
    @darrachequesne
    darrachequesne committed May 22, 2023
    Configuration menu
    Copy the full SHA
    060339a View commit details
    Browse the repository at this point in the history
Loading