Skip to content

Compare protocols case-insensitively #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Compare protocols case-insensitively #67

merged 3 commits into from
Jun 20, 2024

Conversation

ryu-sato
Copy link
Contributor

This PR allows the protocol header of the "101 Switching Protocols" response received from the Websocket server to be compared case-insensitive.

Case-insensitive comparison is because the RFC states that it should be done so.

ref. https://www.rfc-editor.org/rfc/rfc9110.html#name-upgrade

Although protocol names are registered with a preferred case, recipients SHOULD use case-insensitive comparison when matching each protocol-name to supported protocols.

Types of Changes

  • Improvement

Contribution

@ioquatix ioquatix merged commit 000e68e into socketry:main Jun 20, 2024
16 of 18 checks passed
@ioquatix
Copy link
Member

Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants