Updating handling of '*' access-control-allow-origin #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: If a CORS enabled server returns the wildcard origin '*' then the access-control-allow-credentials should not be set. If the server does provied a actual origin in the access-control-allow-origin header then access-control-allow-credentials must be true. Currently there are some inconsitencies in the test in this regard. Modifications: Updated the test with checks to see is check for a '*' origin and verify that access-control-allow-credentials is not set. Also only checking access-control-allow-credentials when there is an explicit origin. Result: All test should still pass.
|
This was recently fixed in sockjs/sockjs-node#177 and the tests actually verify correct behavior |
|
@brycekahle Ah thanks for pointing that out! Will need to fix this on our server side as I got it wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
If a CORS enabled server returns the wildcard origin '*' then the
access-control-allow-credentials should not be set. If the server does
provied a actual origin in the access-control-allow-origin header then
access-control-allow-credentials must be true.
Currently there are some inconsitencies in the test in this regard.
Modifications:
Updated the test with checks to see is check for a '*' origin and verify
that access-control-allow-credentials is not set. Also only checking
access-control-allow-credentials when there is an explicit origin.
Result:
All test should still pass.