Fix cross compiling to Windows with clang-cl #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
Closed
|
Thanks for the patch, just checking the CI is happy with it. Should we put this configuration (targetting msvc from linux for instance) under CI ? |
|
We could do that, the question would be if there are any other C/C++ dependencies that are compiled in, since unfortunately it's not convenient to acquire the MSVCRT or windows libraries on a non-windows platform. |
|
All right. This sounds non-trivial enough. We'll consider we have enough coverage with the windows native build. Merging. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where targeting
x86_64-pc-windows-msvcfrom a non-windows host would fail due to explicit usage oflib.exeandml64.exe. The code now assumes that if that target is used from a non-windows host, the compiler is capable assembling files with the GAS syntax instead.