!fix: Disallow access urls without valid scheme (coder#6548)

Emyrk · web-flow · commit 11a930e77980 · 2023-03-09T21:37:19.000-06:00
Existing deployments will need to prepend a scheme if they have not already.
diff --git a/cli/server.go b/cli/server.go
@@ -295,7 +295,8 @@ flags, and YAML configuration. The precedence is as follows:
 				return xerrors.Errorf("TLS is disabled. Enable with --tls-enable or specify a HTTP address")
 			}
 
-			if cfg.AccessURL.String() != "" && cfg.AccessURL.Scheme == "" {
+			if cfg.AccessURL.String() != "" &&
+				!(cfg.AccessURL.Scheme == "http" || cfg.AccessURL.Scheme == "https") {
 				return xerrors.Errorf("access-url must include a scheme (e.g. 'http://' or 'https://)")
 			}
 

Original file line number	Diff line number	Diff line change
`@@ -295,7 +295,8 @@ flags, and YAML configuration. The precedence is as follows:`
`295`	`295`	`return xerrors.Errorf("TLS is disabled. Enable with --tls-enable or specify a HTTP address")`
`296`	`296`	`}`
`297`	`297`
`298`		`- if cfg.AccessURL.String() != "" && cfg.AccessURL.Scheme == "" {`
	`298`	`+ if cfg.AccessURL.String() != "" &&`
	`299`	`+ !(cfg.AccessURL.Scheme == "http" \|\| cfg.AccessURL.Scheme == "https") {`
`299`	`300`	`return xerrors.Errorf("access-url must include a scheme (e.g. 'http://' or 'https://)")`
`300`	`301`	`}`
`301`	`302`