arguments.md: to_number() bin+hex examples don't work on latest release of Souffle #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#140 was merged in November, to reflect the changes made to souffle in 030e111b (PR #2439 in that project). However, that commit missed the cut for souffle 2.4.1 by about one day. Moreover, the Ubuntu PPA described in the docs has 2.4 as its latest release. Right now, these two binary+hex examples only work if you build souffle from source, containing the
030e111bchangeset.On Souffle 2.4, you'll get 0 as the output of:
At the end of the day, this is a pretty minor nitpick, but I think the docs should note if some example doesn't work on the most recent release. I imagine many users trying Souffle out for the first time are probably installing from rpm/deb, not from source.