Skip to content

refactor #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 25, 2013
Merged

refactor #7

merged 3 commits into from
Dec 25, 2013

Conversation

JasonGitHub
Copy link
Contributor

No description provided.

@soulmachine
Copy link
Owner

Could you add back the comments? I think comments are useful

And please redefine int* d = new int[s.size()]; as vector<int> f(s.size(), 0);, which is the style that comes through the whole book.

@JasonGitHub
Copy link
Contributor Author

Done!

@JasonGitHub
Fixed a bug that might invoke undefined behavior
3f189a3 
Calling front() on an empty container would invoke undefined behavior
soulmachine added a commit that referenced this pull request Dec 25, 2013
@soulmachine
Merge pull request #7 from JasonGitHub/master
ea6d43b 
refactor
@soulmachine soulmachine merged commit ea6d43b into soulmachine:master Dec 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JasonGitHub @soulmachine