Skip to content

Be more graceful about cross-repo navigation error #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 1, 2023
Merged

Be more graceful about cross-repo navigation error #660

merged 2 commits into from
Nov 1, 2023

Conversation

keynmol
Copy link
Contributor

@keynmol keynmol commented Oct 31, 2023 •
edited
Loading

Closes #659

Instead of showing a super long stacktrace, we make it clear that this exception is skippable and will only affect cross-repo navigation.

Here's what it will look like now:

CleanShot 2023-11-01 at 10 56 14

Test plan

N/A

@keynmol keynmol marked this pull request as ready for review November 1, 2023 10:56
@keynmol keynmol merged commit 686acd9 into main Nov 1, 2023
@keynmol keynmol deleted the fix-gradle-publications-error-messages branch November 1, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varungandhi-src varungandhi-src Awaiting requested review from varungandhi-src

1 more reviewer

@olafurpg olafurpg olafurpg approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gradle plugin - don't log the full stack trace for missing publication
2 participants
@keynmol @olafurpg