Skip to content

fix(example): fix errors in example file #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2023
Merged

fix(example): fix errors in example file #687

merged 1 commit into from
Jun 5, 2023

Conversation

GMishx
Copy link
Contributor

@GMishx GMishx commented Jun 5, 2023

Fix the following error/warnings in example script for creating documents from scratch.

WARNING:root:did not find the referenced spdx_id "SPDXRef-Document" in the SPDX document
WARNING:root:ValidationContext(spdx_id=None, parent_id=None, element_type=<SpdxElementType.RELATIONSHIP: 13>, full_element=Relationship(spdx_element_id='SPDXRef-Document', relationship_type=<RelationshipType.DESCRIBES: 14>, related_spdx_element_id='SPDXRef-Package', comment=None))
WARNING:root:did not find the referenced spdx_id "SPDXRef-File1" in the SPDX document
WARNING:root:ValidationContext(spdx_id=None, parent_id=None, element_type=<SpdxElementType.RELATIONSHIP: 13>, full_element=Relationship(spdx_element_id='SPDXRef-Package', relationship_type=<RelationshipType.CONTAINS: 6>, related_spdx_element_id='SPDXRef-File1', comment=None))
WARNING:root:did not find the referenced spdx_id "SPDXRef-File2" in the SPDX document
WARNING:root:ValidationContext(spdx_id=None, parent_id=None, element_type=<SpdxElementType.RELATIONSHIP: 13>, full_element=Relationship(spdx_element_id='SPDXRef-Package', relationship_type=<RelationshipType.CONTAINS: 6>, related_spdx_element_id='SPDXRef-File2', comment=None))

Add the files to package and update the SPDX id describing relationship between document and package.

@GMishx
fix(example): fix errors in example file
09e2a0d 
Add the files to package and update the SPDX id describing relationship between document and package.

Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
armintaenzertng
armintaenzertng approved these changes Jun 5, 2023
View reviewed changes
Copy link
Collaborator

@armintaenzertng armintaenzertng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, very much appreciated! :)

@armintaenzertng armintaenzertng merged commit 1d4ce2d into spdx:main Jun 5, 2023
@armintaenzertng armintaenzertng mentioned this pull request Jun 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armintaenzertng armintaenzertng armintaenzertng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GMishx @armintaenzertng