Skip to content

[issue-692] add test for the example code #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2023
Merged

[issue-692] add test for the example code #694

merged 1 commit into from
Jun 13, 2023

Conversation

armintaenzertng
Copy link
Collaborator

fixes #692

@armintaenzertng armintaenzertng force-pushed the test_the_example branch 2 times, most recently from 003b24a to c66ce60 Compare June 12, 2023 08:57
maxhbr
maxhbr reviewed Jun 12, 2023
View reviewed changes
tests/spdx/examples/test_spdx2_document_from_scratch.py
document.relationships += [contains_relationship1, contains_relationship2]
document.files += [file1, file2]

# We now have created a document with basic creation information, describing a package that contains two files.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there should also be assertions, that the right number of files and relationships are in the document, to check for consistency.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the assertions

@armintaenzertng
[issue-692] add test for the example code
53a3b2f 
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
maxhbr
maxhbr approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@maxhbr maxhbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@armintaenzertng armintaenzertng merged commit f481c16 into spdx:main Jun 13, 2023
@armintaenzertng armintaenzertng deleted the test_the_example branch June 13, 2023 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxhbr maxhbr maxhbr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Getting validation error while running examples\spdx2_document_from_scratch.py
2 participants
@armintaenzertng @maxhbr