Skip to content

[issue-693] TV writer: fix for same file in multiple packages #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

armintaenzertng
Copy link
Collaborator

fixes #693

The problem was that a file belonging to multiple packages would be written out multiple times. This has been fixed. Now, the file is written only for the first package, all other occurrences are modeled as CONTAINS relationships.

Copy link
Member

@maxhbr maxhbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
@armintaenzertng armintaenzertng force-pushed the sameFileInMultiplePackages branch from 27cd66e to 0ef69de Compare June 14, 2023 14:41
@armintaenzertng armintaenzertng merged commit 55c6386 into spdx:main Jun 14, 2023
@armintaenzertng armintaenzertng deleted the sameFileInMultiplePackages branch June 14, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TV parser doesn't deduplicate files
2 participants