Expand writer API to also allow serialization to streams / file objects #700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n always expecting a file name Signed-off-by: Holger Frydrych <holger.frydrych@tngtech.com>
80798ee to
9f5638e
Compare
armintaenzertng
previously approved these changes
Jun 20, 2023
478a80a to
8d1659a
Compare
…writers Signed-off-by: Holger Frydrych <holger.frydrych@tngtech.com>
8d1659a to
50299bd
Compare
9c4a26e to
a9d5313
Compare
than a separate step in the pipeline. Background: there is currently an issue with newer patch versions of Python 3.7 on macos, which are missing bz2 support, thus leading to a failure to include the optional networkx package. This in turn results in that particular test being skipped. But if it runs as a separate step in the pipeline, this means that no tests will execute at all in that step and it will then be marked as an overall failure. See actions/setup-python#682 Signed-off-by: Holger Frydrych <holger.frydrych@tngtech.com>
armintaenzertng
approved these changes
Jun 20, 2023
a9d5313 to
dcc3f5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now, our writers always expect a file name to be provided and then open an output file to write to the given name. This PR adds a set of function that instead allow to pass in a stream / file object, instead. This allows us to pass other types of streams (e.g. in-memory streams) rather than just files and thus makes the API more flexible.