[issue-718] ignore microseconds during datetime conversion to ISO string #719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d5a4bd1 to
ef24be0
Compare
fholger
approved these changes
Jun 30, 2023
| @@ -16,4 +17,11 @@ def datetime_to_iso_string(date: datetime) -> str: | |||
| """ | |||
| Return an ISO-8601 representation of a datetime object. | |||
| """ | |||
| if date.microsecond != 0: | |||
| date = date.replace(microsecond=0) | |||
| logging.warning( | |||
There was a problem hiding this comment.
I'm not 100% convinced this warrants a warning. Since there is no dedicated datetime type without microsecond precision and the most typical way to create a datetime object will add microsecond precision, as a user it might be annoying to deal with those warnings.
But I'm not strictly opposed, either.
There was a problem hiding this comment.
You are probably correct, I removed it.
ef24be0 to
1552364
Compare
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
1552364 to
761900b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #718