Print multiple errors at once #121
Open
+15
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A5rocks
commented
Sep 18, 2024
| @@ -126,8 +125,7 @@ def check_default_role(file, lines, options=None): | |||
| for lno, line in enumerate(lines, start=1): | |||
| line = clean_paragraph(line) | |||
| line = escape2null(line) | |||
| match = rst.INTERPRETED_TEXT_RE.search(line) | |||
| if match: | |||
| for match in rst.INTERPRETED_TEXT_RE.finditer(line): | |||
There was a problem hiding this comment.
I'm not sure about this because all the error messages are the same. On the other hand, this does potentially mean this rules catches offenses that previously it missed (because it just looked at the first possibility).
There was a problem hiding this comment.
Please could you give an example repro to trigger this?
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
Just wanted to bump this! |
|
Addressing @AlexWaygood's performance concerns in #119 (comment), here's how the current Sphinx Lint ❯ hyperfine --warmup 3 "sphinx-lint Doc Misc/NEWS.d --enable=default-role" --ignore-failure
Benchmark 1: sphinx-lint Doc Misc/NEWS.d --enable=default-role
Time (mean ± σ): 1.616 s ± 0.034 s [User: 12.088 s, System: 0.696 s]
Range (min … max): 1.580 s … 1.694 s 10 runs
Warning: Ignoring non-zero exit code.And this PR: ❯ hyperfine --warmup 3 "sphinx-lint Doc Misc/NEWS.d --enable=default-role" --ignore-failure
Benchmark 1: sphinx-lint Doc Misc/NEWS.d --enable=default-role
Time (mean ± σ): 1.680 s ± 0.021 s [User: 12.671 s, System: 0.699 s]
Range (min … max): 1.657 s … 1.728 s 10 runs
Warning: Ignoring non-zero exit code.The PR's time (1.68) is 0.96 times as fast as (96.19%) as the first time (1.616). Is that acceptable? |
That seems fine to me! Thanks for checking! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very basic
.search->.finditerreplacement.There's a few rules where this isn't wanted, because e.g. there's only one possible construct that could fail or because they provide no information in the error message.
Fixes #119