Skip to content

Shorten message on search page #6814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2019
Merged

Conversation

timhoffm
Copy link
Contributor

Subject: Shorten message on search page

Purpose

The text was a bit wordy. It's obvious that the search page can be used to search. Also, we don't need to tell people how to use a search field.

The only relevant content of the paragraph is that matches contain all words. That can be described in one concise sentence, which is more likely to be read than a whole paragraph.

Note: This will need translations updates as a follow-up. Should I update the .po files within this PR? It seems these file are not up-to-date anyway and there would be other changes included.

@codecov
Copy link

codecov bot commented Nov 12, 2019

Codecov Report

Merging #6814 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6814   +/-   ##
=======================================
  Coverage   84.42%   84.42%           
=======================================
  Files         266      266           
  Lines       40474    40474           
  Branches     5934     5934           
=======================================
  Hits        34170    34170           
  Misses       4997     4997           
  Partials     1307     1307

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2d64a9...141db79. Read the comment docs.

Copy link
Member

@tk0miya tk0miya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+0

@tk0miya tk0miya added this to the 2.3.0 milestone Nov 16, 2019
@tk0miya tk0miya merged commit 49e428c into sphinx-doc:master Nov 16, 2019
@tk0miya
Copy link
Member

tk0miya commented Nov 16, 2019

Thank you for your contribution!

@timhoffm timhoffm deleted the search-message branch November 16, 2019 13:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants