Fix #6803: Disable parallel build on macOS and py38+ #6879
Conversation
8304804 to
e742af0
Compare
Codecov Report
@@ Coverage Diff @@
## 2.2.2 #6879 +/- ##
==========================================
- Coverage 83.75% 83.74% -0.01%
==========================================
Files 271 271
Lines 41014 41022 +8
Branches 6002 6003 +1
==========================================
+ Hits 34352 34355 +3
- Misses 5335 5339 +4
- Partials 1327 1328 +1
Continue to review full report at Codecov.
|
| @@ -129,7 +129,7 @@ class TokenProcessor: | |||
| def __init__(self, buffers: List[str]) -> None: | |||
| lines = iter(buffers) | |||
| self.buffers = buffers | |||
| self.tokens = tokenize.generate_tokens(lambda: next(lines)) | |||
| self.tokens = tokenize.generate_tokens(lambda: next(lines)) # type: ignore | |||
There was a problem hiding this comment.
This PR contains #6874 's change.
There was a problem hiding this comment.
LGTM, test behaves as designed and xfails:
tests/test_util_logging.py::test_logging_in_ParallelTasks XFAIL [100%]
============================== 1 xfailed in 0.47s ==============================
and is marked as passing on Python 3.7 and 3.6 at my mac ox x... (the above via make test)
I also tested behavior with -j4. With Python 3.8:
$ make html O=-j4
Sphinx v2.2.2+/e742af060 en cours d'exécution
For security reason, parallel mode is disabled on macOS and python3.8 and above. For more details, please read https://github.com/sphinx-doc/sphinx/issues/6803
and the build proceeds in non-parallel mode, whereas
with Python 3.7.5 parallel build proceeds with no warning. Only to confirm!
|
Thank you for reviewing! Merged. |
Feature or Bugfix
Purpose