FIX Jupyterlite in CircleCI artifact #1336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @lesteve ! |
larsoner
added a commit
to jschueller/sphinx-gallery
that referenced
this pull request
Jun 22, 2024
* upstream/master: MNT: Sort imports and add to pre commit (sphinx-gallery#1337) FIX Jupyterlite in CircleCI artifact (sphinx-gallery#1336)
clrpackages
referenced
this pull request
in clearlinux-pkgs/pypi-sphinx_gallery
Jul 23, 2024
… to version 0.17.0 v0.17.0 ------- Support for Python 3.8 and Sphinx 4 dropped in this release. Requirement is now Python >= 3.9 and Sphinx >= 5. **Implemented enhancements:** - Introduction tooltip corresponds to the first paragraph `#1344 <https://github.com/sphinx-gallery/sphinx-gallery/pull/1344>`__ (`fgmacedo <https://github.com/fgmacedo>`__) - FIX Jupyterlite in CircleCI artifact `#1336 <https://github.com/sphinx-gallery/sphinx-gallery/pull/1336>`__ (`lesteve <https://github.com/lesteve>`__) - MNT: Rename README.rst to GALLERY_HEADER.rst `#1321 <https://github.com/sphinx-gallery/sphinx-gallery/pull/1321>`__ (`timhoffm <https://github.com/timhoffm>`__) - [ENH] Add custom thumbnails for failing examples `#1313 <https://github.com/sphinx-gallery/sphinx-gallery/pull/1313>`__ (`tsbinns <https://github.com/tsbinns>`__) - ENH integrate download/launcher links into ``pydata-sphinx-theme`` secondary sidebar `#1312 <https://github.com/sphinx-gallery/sphinx-gallery/pull/1312>`__ (`Charlie-XIAO <https://github.com/Charlie-XIAO>`__) - add option for zip downloads `#1299 <https://github.com/sphinx-gallery/sphinx-gallery/pull/1299>`__ (`jamiecook <https://github.com/jamiecook>`__) - Allow setting animation format from gallery config `#1243 <https://github.com/sphinx-gallery/sphinx-gallery/pull/1243>`__ (`QuLogic <https://github.com/QuLogic>`__) (NEWS truncated at 15 lines)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while ago, there was some CircleCI limitation that prevented JupyterLite to work inside CircleCI artifact, see #977 (comment) if you are really curious.
It seems something has changed now, but for some reason you need to be explicit and add
index.htmlto the URL, don't ask me why ... edit: I found this very old discussion from 2015 but nothing more recent.Let's try this in this PR!
An example of a recent scikit-learn doc build CircleCI artifact example
The JupyterLite link points to
https://output.circle-artifacts.com/output/job/13caab71-1b1d-444a-b316-93ac215ec6ef/artifacts/0/doc/lite/lab/?path=auto_examples/release_highlights/plot_release_highlights_1_5_0.ipynbwhich showsAdd
index.htmli.e.lite/lab/index.html?path=...instead oflite/lab/?path=...and now it works:https://output.circle-artifacts.com/output/job/13caab71-1b1d-444a-b316-93ac215ec6ef/artifacts/0/doc/lite/lab/index.html?path=auto_examples/release_highlights/plot_release_highlights_1_5_0.ipynb