-
Notifications
You must be signed in to change notification settings - Fork 207
MRG: Add timing information #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #348 +/- ##
==========================================
- Coverage 95.51% 95.51% -0.01%
==========================================
Files 29 29
Lines 2252 2274 +22
==========================================
+ Hits 2151 2172 +21
- Misses 101 102 +1
Continue to review full report at Codecov.
|
@GaelVaroquaux I think this is what you were asking for in #203 (I agree it would be useful in MNE). Feel free to take over to tweak the ReST to taste if you have time (you can push directly to my branch assuming you can as a SG maintainer), or comment here and I can do it. This is what it looks like: It's not the most beautiful thing in the world -- maybe it should be a table. It should probably also show the total computation time, now that I think about it. I haven't linked to it from examples or anywhere else because I consider this summary a "maintainer tool" more than something users would be interested in, given that they can see per-example timings already. |
0c1f0d4
to
49d4f11
Compare
Let's just get this one in and we can make it prettier later. It's mostly an advanced option for devs anyway. There is now a link to it in the configuration page to note its existence. For us it looks pretty trivial: Should be ready for merge for 0.3. |
LGTM - that's a nifty feature! +1 when travis is happy |
Tweaked to include total for the directory https://646-25860190-gh.circle-artifacts.com/0/html/auto_examples/sg_execution_times.html @choldgraf feel free to merge if you are happy |
cool - nice patch! 🎉 |
Closes #203.
Todo: