Skip to content

client: use six.string_types instead of basestring #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 23, 2021
Merged

client: use six.string_types instead of basestring #330

merged 1 commit into from
Dec 23, 2021

Conversation

xrmx
Copy link
Contributor

@xrmx xrmx commented Jun 16, 2020

Which is gone on modern python.

@xrmx xrmx force-pushed the dontusebasestringdirectly branch from 593113e to d9a6fae Compare September 15, 2021 08:58
@ashah-splunk ashah-splunk changed the base branch from master to develop December 7, 2021 16:08
@ashah-splunk ashah-splunk merged commit 69f5040 into splunk:develop Dec 23, 2021
@akaila-splunk akaila-splunk mentioned this pull request Mar 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xrmx @ashah-splunk