Skip to content

JSONResultsReader added and deprecated ResultsReader #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 23, 2022
Merged

JSONResultsReader added and deprecated ResultsReader #441

merged 5 commits into from
Mar 23, 2022

Conversation

ashah-splunk
Copy link
Contributor

  • Added user's approach for JSONResultsReader in place of ResultsReader
  • Newer approach increase efficiency and performance
  • Modified test cases, examples and documentation to use JSONResultsReader along with query param 'output_mode' set to 'json' to use the newer approach
  • Added deprecation warning for the ResultsReader

@ashah-splunk ashah-splunk requested a review from fantavlik March 22, 2022 13:39
fantavlik
fantavlik approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@fantavlik fantavlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! One minor comment - the ResultsReader import in examples/stail.py can be removed.

fantavlik
fantavlik reviewed Mar 22, 2022
View reviewed changes
@ashah-splunk ashah-splunk merged commit 528118b into develop Mar 23, 2022
@akaila-splunk akaila-splunk mentioned this pull request Mar 25, 2022
Merged
@ashah-splunk ashah-splunk deleted the json-resultreader branch April 4, 2022 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fantavlik fantavlik fantavlik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashah-splunk @fantavlik