Always call sleep while restarting #649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ickerday
approved these changes
Aug 27, 2025
41e7604 to
890b7f7
Compare
The /services/server/control/restart endpoint does not stop the API immediately. As a result, a login() call may still succeed just before the restart takes effect. This change introduces an additional sleep to prevent a burst of requests from reaching the server while it is in the process of restarting.
890b7f7 to
be871aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
/services/server/control/restartendpoint does not stop the API immediately. As a result, alogin()call may still succeed just before the restart takes effect. This change introduces an additional sleep to prevent a burst of requests from reaching the server while it is in the process of restarting.