Skip to content
This repository was archived by the owner on Apr 5, 2022. It is now read-only.

Allow spring python YamlConfig to use values as defined in config file rather than forcing coersion to str #2

Merged
merged 5 commits into from
Dec 20, 2011

Conversation

bpedman
Copy link
Contributor

@bpedman bpedman commented Sep 28, 2011

Allow values to be proper type as read from yaml config file instead of forcing coersion to str

@gregturn
Copy link
Contributor

I very much appreciate you coding this patch to enhance SP. However, I would appreciate it if you could code a unit test that exposes this bug so it doesn't regress.

Finally, to accept a patch I need you to sign VMware's contributor license agreement at https://support.springsource.com/spring_committer_signup. Sorry to bug you with this red tape.

@gregturn
Copy link
Contributor

gregturn commented Dec 5, 2011

@bpedman, I really want to accept your patches, but I can't unless you sign the CLA for VMware at https://support.springsource.com/spring_committer_signup.

This project is also test driven, so we need unit tests exposing the bugs these patches fix.

@bpedman
Copy link
Contributor Author

bpedman commented Dec 6, 2011

Sorry, I just haven't had time to write a test for this...I signed the contributor agreement though. I'm not sure when I will be able to write a test for this...maybe I can find time this week

gregturn added a commit that referenced this pull request Dec 20, 2011
Allow spring python YamlConfig to use values as defined in config file rather than forcing coersion to str.
@gregturn gregturn merged commit a491646 into spring-attic:master Dec 20, 2011
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants