Add config file path option to package.json #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request. It would be nice though if you took the time to verify by yourself whether it works. I personally have also fairly little experience with VSCode extension development. I didn't write the original extension. I'm just occasionally maintaining it. I won't be able to just look at the code and say yes this looks good to me. I'd assume you've implemented this as you're personally interested in using this feature. It would then really be in your interests to make sure it works as you're intending it to work. Is there something in particular that stops you from testing it out? Or do you have some concerns about your implementation you're particularly unsure of? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this actually works as I haven't tried it at all and don't really know how to as I've never worked on a VSCode extension before, but I think something like this should work?
Closes sql-formatter-org/sql-formatter#760 maybe.