-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Adds extension-functions.c from http://www.sqlite.org/contrib #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…=date to this distribution. Description: > Provide mathematical and string extension functions for SQL queries using the loadable extensions mechanism. Math: acos, asin, atan, atn2, atan2, acosh, asinh, atanh, difference, degrees, radians, cos, sin, tan, cot, cosh, sinh, tanh, coth, exp, log, log10, power, sign, sqrt, square, ceil, floor, pi. String: replicate, charindex, leftstr, rightstr, ltrim, rtrim, trim, replace, reverse, proper, padl, padr, padc, strfilter. Aggregate: stdev, variance, mode, median, lower_quartile, upper_quartile.
Do you think it's a good idea to include extension functions by default? It makes Maybe it would be a better solution to be able to compile them if needed, with something like |
I understand, I went with this approach since I felt these functions fleshed out SQLite as a fuller database, most people expect a But yes, can make this a separate file. |
…d a normal sql.js without the additional functions
I'm not particularly fond of the things I had to do to the Makefile to do this. Ideas? Thoughts? I feel like we need a cleaner way to do these kinds of builds and testing if more "variants" of SQLite are done. |
It's probably worth noting the size difference here is really small after optimizations (in bytes)
|
Oh, I didn't realise how small the size difference was. And you are right, the Makefile gets really ugly... So, if you think it should be included be default, I think we'll do this. @kripken: what do you think about that? |
Sounds ok to me too, to include by default. |
Thanks, I can make the change to include this by default. |
Let's do it then :) |
Adds extension-functions.c from http://www.sqlite.org/contrib
If you have time, and are still interested in doing awesome things for this project, you can have a look at #128 |
I don't mind, I'll take a look |
I am confused: are the extension-functions somehow availible in sql.js? Because when I test them, I get an error like: "no such function: acos" |
Description: