Make a version of sql.js compiled with ALLOW_MEMORY_GROWTH=1 #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for everyone, keep it up to date as part of releases Closes sql-js#113
* master: Adds `db.getRowsModified` with docs.
|
@lovasoa this is ready for merge as well, would appreciate your thoughts here |
|
Looks ok! Maybe you should mention the existence of this file in the At the end of the README, there is a downloads section. You could update it and mention your new memory growth version. And while you're at it, you could also mention |
|
@lovasoa any update here? |
lovasoa
added a commit
that referenced
this pull request
Mar 18, 2016
Make a version of sql.js compiled with ALLOW_MEMORY_GROWTH=1
|
Oh, sorry, I didn't see your last commit ! |
|
I just merged. Again, sorry for the delay, I thought you hadn't updated the README. |
|
No worries! Thanks for the merge! |
|
I had the same problem with the memory errors and switched to this version but I'm wondering what are the main differences between the two and what important issues this might rise? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make a version of sql.js compiled with ALLOW_MEMORY_GROWTH=1 available for everyone, keep it up to date as part of releases
Closes #113