-
Notifications
You must be signed in to change notification settings - Fork 704
run sqlflow hub on k8s #537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run sqlflow hub on k8s #537
Conversation
|
Seems CI failed at |
Done, released the new version |
$ kubectl exec -it sqlflow-jhub-78f96dcf88-gp8dg bash | ||
``` | ||
|
||
1. Create a user and set a password by the `adduser` command: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid this additional user creation step, you may wanna config dummyauthenticator
by https://github.com/jupyterhub/kubespawner/blob/master/jupyterhub_config.py#L32 .
Please remember to install it using pip install jupyterhub-dummyauthenticator
ref
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we can use the DummyAuthenticator to demonstrate the SQLFlow on k8s, seems PAMAuthenticator is more similar to the production environment.
doc/run_on_kubernetes.md
Outdated
``` | ||
The logs of the Pod similar to: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfinished line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
scripts/start.sh
Outdated
@@ -32,6 +32,9 @@ function setup_mysql() { | |||
for f in /docker-entrypoint-initdb.d/*; do | |||
cat $f | mysql -uroot -proot --host ${SQLFLOW_MYSQL_HOST} --port ${SQLFLOW_MYSQL_PORT} | |||
done | |||
# Grant all privileges to any remote hosts so that the sqlserver can be scaled into more than one replicas. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add tips about configuring this with care in production env.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
related issue: #531