Skip to content

run sqlflow hub on k8s #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Yancey0623
Copy link
Collaborator

related issue: #531

@Yancey0623
Copy link
Collaborator Author

Yancey0623 commented Jun 27, 2019

Should upload the sqlflow wheel package with v0.2.0 firstly.
And we can test this PR by copying the wheel package into the Jupyterhub Pod: kubectl cp sqlflow-0.2.0.dev0-py3-none-any.whl sqlflow-jhub-<POD-ID>:/ and then reinstall this wheel package.

@typhoonzero
Copy link
Collaborator

Seems CI failed at ERROR: No matching distribution found for sqlflow==0.2.0

@Yancey0623
Copy link
Collaborator Author

Seems CI failed at ERROR: No matching distribution found for sqlflow==0.2.0

Done, released the new version pysqlflow==0.2.0

$ kubectl exec -it sqlflow-jhub-78f96dcf88-gp8dg bash
```

1. Create a user and set a password by the `adduser` command:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid this additional user creation step, you may wanna config dummyauthenticator by https://github.com/jupyterhub/kubespawner/blob/master/jupyterhub_config.py#L32 .

Please remember to install it using pip install jupyterhub-dummyauthenticator
ref

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we can use the DummyAuthenticator to demonstrate the SQLFlow on k8s, seems PAMAuthenticator is more similar to the production environment.

```
The logs of the Pod similar to:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfinished line?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

scripts/start.sh Outdated
@@ -32,6 +32,9 @@ function setup_mysql() {
for f in /docker-entrypoint-initdb.d/*; do
cat $f | mysql -uroot -proot --host ${SQLFLOW_MYSQL_HOST} --port ${SQLFLOW_MYSQL_PORT}
done
# Grant all privileges to any remote hosts so that the sqlserver can be scaled into more than one replicas.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add tips about configuring this with care in production env.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

Copy link
Collaborator

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yancey0623 Yancey0623 merged commit 3a846a6 into sql-machine-learning:develop Jul 4, 2019
@Yancey0623 Yancey0623 deleted the run_sqlflow_hub_on_k8s branch July 4, 2019 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants