fixes: #2943, allow overriding validates for inheritance #10574
+95
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15b1be7 to
d310bef
Compare
|
OK...it all works? this is a 2.1 thing then |
sqla-tester
reviewed
Nov 1, 2023
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision d310bef of this pull request into gerrit so we can run tests and reviews and stuff
|
New Gerrit review created for change d310bef: https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/4919 |
sqla-tester
reviewed
Nov 1, 2023
There was a problem hiding this comment.
Federico Caselli (CaselIT) wrote:
left some style suggestions
View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/4919
d310bef to
eab0c56
Compare
Applied the patch mentioned in sqlalchemy#2943, to allow overriding the validates method of a given Model, Added tests for same in test_validators. If a Child class overrides the parent class validates method only child class validator will be invoked unless child class explicitly invokes parent class validator
eab0c56 to
9c3d510
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applied the patch mentioned in #2943, to allow overriding the validates method of a given Model, Added tests for same in test_validators.
If a Child class overrides the parent class validates method only child class validator will be invoked unless child class explicitly invokes parent class validator
Description
Checklist
This pull request is:
include a complete example of how the feature would look.
Fixes: #<issue number>in the commit messageHave a nice day!