Make loader strategy error message more verbose #12401
Open
+22
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzzeek
reviewed
Mar 5, 2025
80a6ff4 to
b15a462
Compare
Fixes: sqlalchemy#12398 this commit makes the error message on conflicting loader strategies more verbose to help with debugging
b15a462 to
41ebcaf
Compare
CaselIT
reviewed
Mar 5, 2025
| r"Loader strategy replacement " | ||
| r"ORM Path\[Mapper\[Order\(orders\)\] -> Order.user_id\] " | ||
| r"is in conflict with existing strategy " | ||
| r"ORM Path\[Mapper\[Order\(orders\)\] -> Order.user_id\]", |
There was a problem hiding this comment.
ok this doesn't seem to add much value, since the two sides are the same.
@zzzeek do we have also a way of getting what option is used in each part of the path?
There was a problem hiding this comment.
I thought bringing in _LoadElement.strategy might add more value to this, but I realised that it is also equal in a lot of cases.
There was a problem hiding this comment.
im not really sure, I haven't looked at this code in a long time. I do know it's vastly simpler code than it was in 1.4 and earlier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #12398
This PR makes the error message on conflicting loader strategies more verbose to help with debugging
Description
I changed the omitted error messages and the tests covering it.
Checklist
This pull request is:
must include a complete example of the issue. one line code fixes without an
issue and demonstration will not be accepted.
Fixes: #<issue number>in the commit messageinclude a complete example of how the feature would look.
Fixes: #<issue number>in the commit messageHave a nice day!