-
Notifications
You must be signed in to change notification settings - Fork 366
Add support for Explain Analyze for Postgres v13 #1230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the code is currently used only by the Query Plan Guidance (QPG) component. If we execute ANALYZE
for it, performance would drop. I guess we could have separate public methods, one for QPG and one that we use in the provider class.
I see, looking over the |
We could add an enum (see
EXPLAIN , while we can keep using the restricted method for QPG.
|
@yaojiejia, I see you have been working on multiple other PRs. Do you think it would be possible to focus on the open ones, so we can merge those first? |
Of course, will prioritize these for now, thanks |
Just included a method for EXPLAIN. Lmk if this is something we are looking for |
Closes 12. EXPLAIN ANALYSE from #912