Skip to content

Conversation

yaojiejia
Copy link
Contributor

Closes #1242

@mrigger
Copy link
Contributor

mrigger commented Jun 17, 2025

Sorry for the delay in reviewing. I have been traveling and did not see this PR.

It seems given that EXTRACT has a special syntax, and the current implementation introduces some additional checks at multiple places to deal with them. I think this is not ideal in terms of OOP. Would it be possible to have a special subclass and implement the variability in methods that are overwritten?

@yaojiejia
Copy link
Contributor Author

Sorry for the delay in reviewing. I have been traveling and did not see this PR.

It seems given that EXTRACT has a special syntax, and the current implementation introduces some additional checks at multiple places to deal with them. I think this is not ideal in terms of OOP. Would it be possible to have a special subclass and implement the variability in methods that are overwritten?

Sounds good, just made some changes about that

Copy link
Contributor

@mrigger mrigger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mrigger
Copy link
Contributor

mrigger commented Aug 22, 2025

I just noticed that there is a test failure (" time zone "g+zvi" not recognized"). Could you run the changed implementation for longer to check whether there are other errors that need to be added as expected errors?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PostgreSQL Version 14 Upgrade - Supporting EXTRACT() Function
2 participants