Serialize StateToReproduce to JSON #1261
Conversation
f3352e8 to
a9cd21c
Compare
|
Why do we convert it to JSON? Can we not just use the Java serialization API? |
Yes. I used JSON for readability, but Java serialization is indeed simpler. I’m fine switching to that. |
- Replaced JSON with Java serialization in StateToReproduce - Removed unused getters from StateToReproduce
|
Sorry for the delay and thanks for pinging me, @KabilanMA. I think this could be simplified a lot. At a high level, I see what we are adding an additional class |
|
Yes, we can serialize I added @KabilanMA @mrigger Does this sound good to you? |
|
We can serialize the Either approach is valid; it ultimately comes down to maintainability. Keeping a separate serializable class provides better clarity and separation of concerns, especially if |
|
I think we'd add much technical depth by proceeding with having these additional fields and classes. Essentially, we already have all the information we need in the relevant objects. Converting things to a more low-level representation and having fields such as |
|
Agreed. |
Motivation
To support a standalone reducer in SQLancer, we need a way to serialize the
StateToReproduceobject, which encapsulates all the information needed to reproduce a bug.Solution
StateToReproduceinto a JSON file when a bug is found.statements,errorType(EXCEPTION, NOREC, TLP_WHERE),databaseName,databaseProvider,reproducerData,exception--serialize-reproduce-state, and serialized.jsonfiles are written tologs/<dbms>/reproduce/.StateToReproduceSerializoris introduced to control which fields are included in the output.Example Output
{ "statements": [ "CREATE VIRTUAL TABLE rt0 USING rtree(c0, c1, c2, c3, c4);", ... ], "databaseName": "database6", "databaseProvider": "sqlancer.sqlite3.SQLite3Provider", "errorType": "NOREC", "expectedErrorsMap": { "INSERT OR FAIL INTO rt0 VALUES (NULL, 0.9105867290640974, \u0027\u0027, x\u00270a74\u0027, NULL), (x\u0027\u0027, NULL, 0x3cef0261, NULL, NULL), (\u0027280862872\u0027, \u00271022296673\u0027, \u0027n\u0027, x\u0027c9c3f71d\u0027, NULL);": [ "[SQLITE_CONSTRAINT] Abort due to constraint violation (rtree constraint failed: rt0.(c1\u003c\u003dc2))" ], ... }, "reproducerData": { "optimizedQueryString": "SELECT COUNT(*) FROM rt0 WHERE (((SQLITE_SOURCE_ID())\u003c\u003d(rt0.c4)))", "unoptimizedQueryString": "SELECT SUM(count) FROM (SELECT ((((SQLITE_SOURCE_ID())\u003c\u003d(rt0.c4))) IS TRUE) as count FROM rt0)", "shouldUseAggregate": "true" } }