Skip to content

fix(engine/mysql): Update incorrect signatures #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2021
Merged

fix(engine/mysql): Update incorrect signatures #1180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions internal/endtoend/testdata/mysql_reference_manual/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
All queries and examples in this directory come from the [MySQL Reference
Manual](https://dev.mysql.com/doc/refman/8.0/en/).
24 changes: 24 additions & 0 deletions internal/endtoend/testdata/mysql_reference_manual/date_and_time_functions/date_add.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
-- https://dev.mysql.com/doc/refman/8.0/en/date-and-time-functions.html#function_date-add

-- name: DateAddOneDay :one
SELECT DATE_ADD('2018-05-01',INTERVAL 1 DAY);

-- name: DateAddOneSecond :one
SELECT DATE_ADD('2020-12-31 23:59:59',
INTERVAL 1 SECOND);

-- name: DateAddTimestampOneSecond :one
SELECT DATE_ADD('2018-12-31 23:59:59',
INTERVAL 1 DAY);

-- name: DateAddMinuteSecond :one
SELECT DATE_ADD('2100-12-31 23:59:59',
INTERVAL '1:1' MINUTE_SECOND);

-- name: DateAddDayHour :one
SELECT DATE_ADD('1900-01-01 00:00:00',
INTERVAL '-1 10' DAY_HOUR);

-- name: DateAddSecondMicrosecond :one
SELECT DATE_ADD('1992-12-31 23:59:59.000002',
INTERVAL '1.999999' SECOND_MICROSECOND);
9 changes: 9 additions & 0 deletions internal/endtoend/testdata/mysql_reference_manual/date_and_time_functions/date_sub.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
-- name: DateSubOneYear :one
SELECT DATE_SUB('2018-05-01',INTERVAL 1 YEAR);

-- name: DateSubDaySecond :one
SELECT DATE_SUB('2025-01-01 00:00:00',
INTERVAL '1 1:1:1' DAY_SECOND);

-- name: DateSub31Days :one
SELECT DATE_SUB('1998-01-02', INTERVAL 31 DAY);
82 changes: 82 additions & 0 deletions internal/endtoend/testdata/mysql_reference_manual/date_and_time_functions/go/date_add.sql.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

43 changes: 43 additions & 0 deletions internal/endtoend/testdata/mysql_reference_manual/date_and_time_functions/go/date_sub.sql.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

29 changes: 29 additions & 0 deletions internal/endtoend/testdata/mysql_reference_manual/date_and_time_functions/go/db.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions internal/endtoend/testdata/mysql_reference_manual/date_and_time_functions/go/models.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 12 additions & 0 deletions internal/endtoend/testdata/mysql_reference_manual/sqlc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"version": "1",
"packages": [
{
"name": "date_and_time_functions",
"path": "date_and_time_functions/go",
"schema": "date_and_time_functions",
"queries": "date_and_time_functions",
"engine": "mysql"
}
]
}
6 changes: 6 additions & 0 deletions internal/engine/dolphin/stdlib.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,6 +630,9 @@ func defaultSchema(name string) *catalog.Schema {
{
Type: &ast.TypeName{Name: "any"},
},
{
Type: &ast.TypeName{Name: "any"},
},
},
ReturnType: &ast.TypeName{Name: "date"},
},
Expand Down Expand Up @@ -666,6 +669,9 @@ func defaultSchema(name string) *catalog.Schema {
{
Type: &ast.TypeName{Name: "any"},
},
{
Type: &ast.TypeName{Name: "any"},
},
},
ReturnType: &ast.TypeName{Name: "date"},
},
Expand Down