feat(compiler): Support LEFT JOIN on aliased table #2873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleconroy
commented
Oct 17, 2023
Comment on lines
+427
to
434
| tableMatch := *n.Relname == col.Table.Name | ||
| aliasMatch := true | ||
| if n.Alias != nil && col.TableAlias != "" { | ||
| aliasMatch = *n.Alias.Aliasname == col.TableAlias | ||
| } | ||
| if n.Alias != nil && *n.Alias.Aliasname == col.TableAlias && *n.Relname == col.Table.Name { | ||
| if aliasMatch && tableMatch { | ||
| return prior | ||
| } |
There was a problem hiding this comment.
If the column doesn't use a table alias, don't check that the aliases match.
There was a problem hiding this comment.
Seems correct logically, although aliasMatch defaulting to true is potentially confusing to future readers. I might suggest just putting this comment you wrote in the actual source.
andrewmbenton
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1897